Update submodule with type ordering changes#1236
Merged
jakebailey merged 1 commit intomainfrom Jun 19, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the TypeScript submodule baselines to reflect upstream changes in how union member orders are printed.
- Adjusted expected output in multiple
.types.difffiles where unions are reordered (e.g.,object | Tinstead ofT | object). - Bumped the submodule commit pointer to include those ordering changes.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testdata/.../templateLiteralTypes3.types.diff | Swapped the order of union members in output. |
| testdata/.../spreadObjectOrFalsy.types.diff | Updated the printed order for `object |
| testdata/.../nonPrimitiveAndTypeVariables.types.diff | Removed outdated diff block for this test. |
| testdata/.../nonPrimitiveAndTypeVariables.errors.txt.diff | Removed outdated error baseline for this test. |
| testdata/.../inOperatorWithValidOperands.types.diff | Swapped union member order in display. |
| testdata/.../inOperatorWithValidOperands.errors.txt.diff | Removed outdated error baseline for this test. |
| testdata/.../generatorYieldContextualType.types.diff | Swapped order of selection union in output. |
| testdata/.../conditionalTypes2.types.diff | No functional changes, baseline skip markers. |
| testdata/.../vueLikeDataAndPropsInference2.types.diff | Adjusted union order in printed function signature. |
| testdata/.../unionOfFunctionAndSignatureIsCallable.types.diff | Harmonized union order in signatures. |
| testdata/.../typeGuardConstructorClassAndNumber.types.diff | Swapped union order in function signature. |
| testdata/.../objectLiteralExcessProperties.types.diff | Swapped union order in printed object type. |
| testdata/.../correlatedUnions.types.diff | Swapped type inferences for assertedCheck. |
| _submodules/TypeScript | Bumped TypeScript submodule commit reference. |
DanielRosenwasser
approved these changes
Jun 19, 2025
andrewbranch
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the submodule after I ported #1226 into the tsgo-port branch upstream.